Measuring Root Mass updated results#362
Measuring Root Mass updated results#362marcodallavecchia wants to merge 3 commits intodatacarpentry:mainfrom
Conversation
Thank you!Thank you for your pull request 😃 🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}. If you have files that automatically render output (e.g. R Markdown), then you should check for the following:
Rendered Changes🔍 Inspect the changes: https://github.com/datacarpentry/image-processing/compare/md-outputs..md-outputs-PR-362 The following changes were observed in the rendered markdown documents: What does this mean?If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation. ⏱️ Updated at 2026-03-24 20:18:48 +0000 |
uschille
left a comment
uschille
left a comment
There was a problem hiding this comment.
Thank you @marcodallavecchia! This looks good, I am getting the same results on my end.
K-Meech
left a comment
K-Meech
left a comment
There was a problem hiding this comment.
Thanks @marcodallavecchia - looks great! Really like your reproducibility explanation.
There were a few other places in the lesson I found slightly different - not sure if you want to update those too for the sake of completeness?
- In the 'Automatic thresholding' section, I had a slightly different value for the
Found automatic threshold t = 0.4172454549881862.line - In the challenge solution for 'Ignoring more of the images - implementation', the printed values per file were also slightly different
|
Thanks a lot for the thoroughness @K-Meech! I clearly missed other spots where those values might have been different. I tried to go through it one more time, and I updated the ones you mentioned but found no additional ones. Let me know what you think now! |
3 participants
This PR addresses #351 by re-running the existing code on the same test data with the latest version of the environment packages described in
episodes/files/environment.yml.Here's what I've done:
conda env create --file episodes/files/environment.ymlconda activate dc-imageThese steps result in slightly different values than the ones we have currently on the webpage. I updated both the single value in line 515 and the output block lines 535-540 in
episodes/07-thresholding.mdwith the new values.Because the print order of the files was non-alphabetical in my case, I took the freedom to add
sortedin line 528, to ensure alphabetical ordering of the print statements.Finally, I added a callout block below the output to highlight the challenges of a reproducible environment. Please let me know if you like the way it's phrased and laid out.
I re-rendered the website locally before pushing to verify everything rendered correctly.